[Header Mode] Elide property initializers #5572
Conversation
…olved for header compilation. ^KT-78422
^KT-78422,KT-82336
FenstonSingel
requested review from
demiurg906
and removed request for
FenstonSingel and
bashor
demiurg906
left a comment
demiurg906
left a comment
There was a problem hiding this comment.
In addition to the comments above, could you please squash all commits in this branch into one?
They all are about the same thing with a small variations and it's not very practical to have them separated.
OFC fixes to comments would be nice to have in !fixup commits to this big squashed one.
| if (!initializerIsAlreadyResolved) { | ||
| dataFlowAnalyzer.enterProperty(property) | ||
| } | ||
| else if ( |
There was a problem hiding this comment.
This branch is actually useless, as you anyway remove the initializer in the end of the transformProperty.
| else -> if (it.isExpression()) { | ||
| context.calleeNamesForLambda += null | ||
| propertyInitializer = withForcedLocalContext { | ||
| propertyInitializer = withForcedLocalContext(!isReturnType || modifiers?.isConst() == true) { |
There was a problem hiding this comment.
Setting forceKeepingTheBodyInHeaderMode here actually doesn't do anything, as this property affects only transformFunctionBody, and here we call just getAsFirExpression, which unconditionally creates an expression.
Here you should just don't call getAsFirExpression if isReturnType && modifiers?.isConst() != true.
2 participants
https://youtrack.jetbrains.com/issue/KT-78422/
Fixes https://youtrack.jetbrains.com/issue/KT-82336/